Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make the return value of accessToken nullable #641

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix: make the return value of accessToken nullable #641

merged 1 commit into from
Jan 16, 2025
+7 −7

Conversation

grdsdev
Copy link
Collaborator

@grdsdev grdsdev commented Jan 16, 2025

What kind of change does this PR introduce?

fix

What is the current behavior?

Currently nil cannot be returned from accessToken function.

What is the new behavior?

nil can be returned from accessToken when the user on the third-party auth is not signed in.

Additional context

supabase/supabase-js#1332

@grdsdev grdsdev requested review from hf and dshukertjr January 16, 2025 12:23
@grdsdev grdsdev merged commit af9b774 into main Jan 16, 2025
21 of 22 checks passed
@grdsdev grdsdev deleted the fix/nullable-accessToken branch January 16, 2025 17:40
@github-actions github-actions bot mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshukertjr dshukertjr dshukertjr approved these changes

@hf hf Awaiting requested review from hf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grdsdev @dshukertjr